[PATCH] D140555: [lld][COFF]llvm-readobj COFFDumper print PEHeader CheckSum

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 09:08:05 PST 2022


aganea added a comment.

I think you might need to update some other tests. Have you ran `ninja check-all`? I see at least `llvm/test/tools/llvm-readobj/COFF/file-headers.test` might fail because of this change, there could be others. Ideally you could use cmake with `-DLLVM_ENABLE_PROJECTS="llvm;clang;lld;clang-tools-extra;mlir"`to ensure you have good coverage for `ninja check-all`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140555/new/

https://reviews.llvm.org/D140555



More information about the llvm-commits mailing list