[PATCH] D139209: [IRMover] Remove UB implying parameter attributes when necessary

[Gulfem Savrun Yeniceri via Phabricator via llvm-commits]

gulfem added a comment.

In D139209#4008098 <https://reviews.llvm.org/D139209#4008098>, @tejohnson wrote:

> Sorry for the delay, I had another review of attribute updates come in (D137360 <https://reviews.llvm.org/D137360>), can you work with @gulfem to have a consistent place to do these updates? I'm thinking that there could be a single "updateAttributes" function, and in there you could invoke your ensureFunctionCompatibility if New is still a declaration (see D137360 <https://reviews.llvm.org/D137360>, I've suggested removeAttributes be renamed to updateAttributes).

@TimNN,
Based on @tejohnson 's suggestion, I renamed the function to `updateAttributes` in D137360 <https://reviews.llvm.org/D137360>. How would you like to coordinate? I'm thinking that I can land D137360 <https://reviews.llvm.org/D137360>, and you can extend `updateAttributes()` function to include a src and dest arguments, and call your `ensureFunctionCompatibility()` function from there. Does that sound good or do you have another suggestion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139209/new/

https://reviews.llvm.org/D139209