[PATCH] D139209: [IRMover] Remove UB implying parameter attributes when necessary

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 08:08:46 PST 2022


tejohnson added a subscriber: gulfem.
tejohnson added a comment.

Sorry for the delay, I had another review of attribute updates come in (D137360 <https://reviews.llvm.org/D137360>), can you work with @gulfem to have a consistent place to do these updates? I'm thinking that there could be a single "updateAttributes" function, and in there you could invoke your ensureFunctionCompatibility if New is still a declaration (see D137360 <https://reviews.llvm.org/D137360>, I've suggested removeAttributes be renamed to updateAttributes).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139209/new/

https://reviews.llvm.org/D139209



More information about the llvm-commits mailing list