[PATCH] D140147: [RISCV][InsertVSETVLI] Rewrite scalar insert forward rule in terms of demanded fields

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 22:41:04 PST 2022


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:235
 
   // For vmv.s.x and vfmv.s.f, there is only two behaviors, VL = 0 and VL > 0.
+  if (isScalarMoveInstr(MI)) {
----------------
while you're here

"is only" -> "are only"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140147/new/

https://reviews.llvm.org/D140147



More information about the llvm-commits mailing list