[PATCH] D140405: [CVP] Simplify SRem when constantrange abs(lhs) < abs(rhs)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D140405#4008367 <https://reviews.llvm.org/D140405#4008367>, @nikic wrote:

> In D140405#4008361 <https://reviews.llvm.org/D140405#4008361>, @nikic wrote:
>
>> Proof: https://alive2.llvm.org/ce/z/ExGwu7
>
> Actually, this shows that this is not correct as implemented: You should always simplify to LHS, independent of RHS sign. `srem` result has the same sign as LHS, not RHS.

Looks like the `srem.ll` is missing such test, too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140405/new/

https://reviews.llvm.org/D140405