[PATCH] D140405: [CVP] Simplify SRem when constantrange abs(lhs) < abs(rhs)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 09:20:48 PST 2022


nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.

In D140405#4008361 <https://reviews.llvm.org/D140405#4008361>, @nikic wrote:

> Proof: https://alive2.llvm.org/ce/z/ExGwu7

Actually, this shows that this is not correct as implemented: You should always simplify to LHS, independent of RHS sign. `srem` result has the same sign as LHS, not RHS.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140405/new/

https://reviews.llvm.org/D140405



More information about the llvm-commits mailing list