[PATCH] D139644: [InlineAdvisor] Allow loading advisors as plugins

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/unittests/Analysis/CMakeLists.txt:19
 
+# If plugins are disabled, the PluginInlineAdvisorTest will disable itself at runtime. 
+# Otherwise, reconfiguring with plugins disabled will leave behind a stale executable.
----------------
thakis wrote:
> mtrofin wrote:
> > Use `include/llvm/Config/llvm-config.h.cmake` instead define the preprocessor macro.
> Also, why did 7d2c1150d31bb remove the comment together with the define? The comment seems useful independent of the define.
As the define becomes available part of llvm-config.h (or config.h - separate issue), there's nothing left to comment on in the cmake, and there's a comment to the same effect in PluginsTest.cpp.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139644/new/

https://reviews.llvm.org/D139644