[PATCH] D139644: [InlineAdvisor] Allow loading advisors as plugins

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/unittests/Analysis/PluginInlineAdvisorAnalysisTest.cpp:64
+    Expected<PassPlugin> Plugin = PassPlugin::Load(PluginPath);
+    ASSERT_TRUE(!!Plugin) << "Plugin path: " << PluginPath;
+    Plugin->registerPassBuilderCallbacks(PB);
----------------
thakis wrote:
> This test is added unconditionally and doesn't check LLVM_ENABLE_PLUGINS as far as I can tell. How does this work with plugins disabled?
The check for LLVM_ENABLE_PLUGINS is below on line 262. Sorry for the noise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139644/new/

https://reviews.llvm.org/D139644