[PATCH] D136043: [CodeGen] Replace CCValAssign::Loc with a discriminated union (NFCI)

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 17 12:17:31 PST 2022


barannikov88 added a comment.

In D136043#4003356 <https://reviews.llvm.org/D136043#4003356>, @tschuett wrote:

> Does it become easier, if you introduce the `int64_t` in this patch?

Changing the type to `int64_t` is not a local change, it will bloat the patch considerably and make it harder to review.
I also don't want to change the type to int64_t before this patch, because `unsigned Loc;` is shared between Register and Memory and Pending variants, and changing it to int64_t does not look right.
What do you say if I ping you after the second patch lands so that you can exercise `std::variant` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136043/new/

https://reviews.llvm.org/D136043



More information about the llvm-commits mailing list