[PATCH] D136043: [CodeGen] Replace CCValAssign::Loc with a discriminated union (NFCI)

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 17 12:02:17 PST 2022


tschuett added a comment.

I cannot stop you, but I prefer variant over unions. Does it become easier, if you introduce the `int64_t` in this patch? You could put the documentation above the variant?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136043/new/

https://reviews.llvm.org/D136043



More information about the llvm-commits mailing list