[PATCH] D140227: [dsymutil] Verify the keep chain when asserts are enabled

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 17 03:06:33 PST 2022


avl added inline comments.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:877
+
+    for (DWARFDie Child : reverse(Current.children())) {
+      Worklist.push_back(Child);
----------------
it looks not neccessary to reverse here.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:886
+
+  if (!BrokenLinks.empty()) {
+    for (BrokenLink Link : BrokenLinks) {
----------------
this check looks redundant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140227/new/

https://reviews.llvm.org/D140227



More information about the llvm-commits mailing list