[PATCH] D140227: [dsymutil] Verify the keep chain when asserts are enabled

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:2597
+#ifndef NDEBUG
+        verifyKeepChain(*CurrentUnit);
+#endif
----------------
aprantl wrote:
> Since `dsymutil` accepts `--verify` should this maybe be in all builds and enable by that flag?
The verify option checks the validity of the input and/or output dwarf. The verification done here is strictly enforcing an implementation variant, like an assert. I think that besides the name there's not enough overlap to make it part of that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140227/new/

https://reviews.llvm.org/D140227