[PATCH] D139419: [AArch64] lower abs intrinsic to new ABS instruction in GIsel

Fri Dec 16 11:23:04 PST 2022

paquette added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/select-abs.mir:4

 ...
 ---
----------------
stuij wrote:
> paquette wrote:
> > The codegen here didn't change at all.
> > 
> > Is it possible to select the scalar abs right now? Should there be a scalar testcase here?
> No, there should not be a scalar testcase here. I tested this at some point and must have decided that CHECK-NEXT is better than NEXT, so why not add it to the patch.
Yeah the `update_mir_test_checks` script was updated a while back to use `CHECK-NEXT`. Which is probably better, but introduces a lot of noise to the blamelist when we're updating our tests. :(

I'd recommend not updating this test if you're not actually modifying codegen in this patch. If only because it shows up in the blamelist and makes the commit history a little more confusing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139419/new/

https://reviews.llvm.org/D139419