[PATCH] D139419: [AArch64] lower abs intrinsic to new ABS instruction in GIsel

Ties Stuij via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 09:15:51 PST 2022


stuij marked an inline comment as done.
stuij added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/select-abs.mir:4
 
 ...
 ---
----------------
paquette wrote:
> The codegen here didn't change at all.
> 
> Is it possible to select the scalar abs right now? Should there be a scalar testcase here?
No, there should not be a scalar testcase here. I tested this at some point and must have decided that CHECK-NEXT is better than NEXT, so why not add it to the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139419/new/

https://reviews.llvm.org/D139419



More information about the llvm-commits mailing list