[PATCH] D139006: [UpdateTestChecks] Match define for labels
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 16 04:58:08 PST 2022
spatel added a comment.
In D139006#4000992 <https://reviews.llvm.org/D139006#4000992>, @sebastian-ne wrote:
> Adding `--function-signature` by default sounds like a good idea to me.
> Is there any reason why we wouldn’t want to enable this by default (for new tests)?
No objection from me for new files. There's some small time cost for added checks, but AFAIK nobody cares about that, so the added verification to also make sure we didn't accidentally swap function args during regex is worth it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139006/new/
https://reviews.llvm.org/D139006
More information about the llvm-commits
mailing list