[PATCH] D139006: [UpdateTestChecks] Match define for labels

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 04:40:37 PST 2022


sebastian-ne added a comment.

> I believe the motivation here is the default behavior

Correct, update_test_checks produces a broken test for some input and I think this is a bug that we should fix.

Sorry for the test churn and thanks for the revert (I only got to work a few hours after nikic already reverted).

> That's why I'm suggesting to change the default behavior for new tests

Adding `--function-signature` by default sounds like a good idea to me.
Is there any reason why we wouldn’t want to enable this by default (for new tests)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139006/new/

https://reviews.llvm.org/D139006



More information about the llvm-commits mailing list