[PATCH] D140161: [SelectionDAG] Give all the target specific subclasses of SelectionDAGISel their own pass ID.

Thu Dec 15 13:25:39 PST 2022

nickdesaulniers added a comment.

In D140161#3999328 <https://reviews.llvm.org/D140161#3999328>, @nickdesaulniers wrote:

> Or was there another invocation of `llc` where you observed this?

Doesn't `-print-after-all` only print if changes were made (given for `finalize-isel`)? Rerunning my above tests with `-print-after-all` rather than `-print-before-all` I still see `finalize-isel`. I think this confirms that D140161 <https://reviews.llvm.org/D140161> does not break `-print-after-all`/`-print-before-all`.

(Though one curiosity I do see for `llc -mtriple=aarch64-linux-gnu /tmp/x.ll -stop-after=finalize-isel -o - -print-after-all` is that MIR is printed after `aarch64-local-dynamic-tls-cleanup` which runs before `finalize-isel`; WAT?!)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140161/new/

https://reviews.llvm.org/D140161