[PATCH] D140161: [SelectionDAG] Give all the target specific subclasses of SelectionDAGISel their own pass ID.

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added a comment.

Thanks for the (quick) patch!

> Unfortunately, I think this causes most targets to lose
> print-before/after-all support for their SelectionDAGISel pass.

I now see:

`# *** IR Dump After Finalize ISel and expand pseudo-instructions (finalize-isel) ***:`

for `llc -mtriple=x86_64-linux-gnu /tmp/x.ll -stop-after=finalize-isel -o - -print-before-all`
(good) and `-mtriple=aarch64-linux-gnu` (good). So perhaps that can perhaps be dropped from the commit message. Or was there another invocation of `llc` where you observed this?

> And they probably no longer support start/stop-before/after.

Let's check that too!

When I apply this on top of my stack o' patches: https://reviews.llvm.org/D140160, my tests running `-start-before=amdgpu-isel` both fail.

> LLVM ERROR: Cannot stop compilation after pass that is not run

This is expected (good).

Now let's see if I can change `-start-before=amdgpu-isel` to `-start-before=finalize-isel`...
and test's fail with no output.  So indeed seems like we'll need that part 2.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140161/new/

https://reviews.llvm.org/D140161