[PATCH] D140119: [PowerPC][GIsel] Materialize i64 constants.

[Thorsten via Phabricator via llvm-commits]

tschuett added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCInstructionSelector.cpp:573
+  // 3-2) Pattern : {zeros}{31-bit value}{ones}
+  // Shift right the Imm by (32 - LZ) bits to construct a negtive 32 bits value,
+  // therefore we can take advantage of LIS's sign-extension semantics, add
----------------
negative 


================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCInstructionSelector.cpp:689
+  int64_t Imm = I.getOperand(1).getCImm()->getValue().getZExtValue();
+  // No more than 3 instructions is used if we can select the i64 immediate
+  // directly.
----------------
are


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140119/new/

https://reviews.llvm.org/D140119