[PATCH] D140119: [PowerPC][GIsel] Materialize i64 constants.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCInstructionSelector.cpp:692-693
+  if (std::optional<bool> Res = selectI64ImmDirect(I, MBB, MRI, DstReg, Imm)) {
+    if (*Res)
+      I.eraseFromParent();
+    return *Res;
----------------
You can just unconditionally erase, if it failed the whole function's getting deleted anyway


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140119/new/

https://reviews.llvm.org/D140119