[PATCH] D139673: [AMDGPU][SIFrameLowering] Mark VGPR used for AGPR spills as reserved

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineRegisterInfo.h:906
+  void reserveReg(MCRegister PhysReg) {
+    ReservedRegs.set(PhysReg);
+  }
----------------
This needs to consider all aliasing registers. This also needs a warning that this cannot be used in the middle of a walk in a function or when you have liveness info available


================
Comment at: llvm/include/llvm/CodeGen/MachineRegisterInfo.h:910
+  /// unreserveReg -- Mark a register as not reserved so checks like isAllocatable
+  /// will suggest using it.
+  void unreserveReg(MCRegister PhysReg) {
----------------
Ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139673/new/

https://reviews.llvm.org/D139673