[PATCH] D139386: [RISCV][THEAD] Vendor extensions: Add 'XTheadVdot' T-Head vendor extensions

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoXTHeadV.td:29
+  let Opcode = OPC_CUSTOM_0.Value;
+}
+
----------------
Missing DecoderNamespace?


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoXTHeadV.td:61
+//===----------------------------------------------------------------------===//
+let Predicates = [HasVendorXTHeadVdot] in {
+let Constraints = "@earlyclobber $vd" in {
----------------
Merge these into a single `let`?


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoXTHeadVPseudo.td:21
+
+defset list<VTypeInfoToWide> AllQuadenableInt8NoVLMulVectors = {
+  def : VTypeInfoToWide<VI8MF2,  VI32MF2>;
----------------
Quadenable -> QuadWidenable.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoXTHeadVPseudo.td:59
+multiclass VPatTernaryVMAQA_VX<string intrinsic, string instruction,
+                           list<VTypeInfoToWide> vtilist> {
+  foreach vtiToWti = vtilist in {
----------------
indent this 4 more spaces


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoXTHeadVPseudo.td:72
+multiclass VPatTernaryVMAQA_VV_VX<string intrinsic, string instruction,
+                              list<VTypeInfoToWide> vtilist>
+    : VPatTernaryVMAQA_VV<intrinsic, instruction, vtilist>,
----------------
indent this 4 more spaces


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139386/new/

https://reviews.llvm.org/D139386