[PATCH] D140046: [PowerPC] Fix up memory ordering after combining BV to a load

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14262
 
+  SmallPtrSet<LoadSDNode *, 4> InputLoads;
   for (int i = 1, e = N->getNumOperands(); i < e; ++i) {
----------------
Do we really need a SmallPtrSet here?  We check each load exactly once, so we should be able to just use a SmallVector.

Iterating over a SmallPtrSet like this might lead to non-determinism.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140046/new/

https://reviews.llvm.org/D140046