[PATCH] D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size (WIP)

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 09:12:12 PST 2022


vpykhtin marked an inline comment as done.
vpykhtin added inline comments.


================
Comment at: llvm/include/llvm/MC/LaneBitmask.h:85-88
     static constexpr LaneBitmask getLane(unsigned Lane) {
       return LaneBitmask(Type(1) << Lane);
     }
+    static constexpr LaneBitmask getLanes(unsigned NumLanes) {
----------------
arsenm wrote:
> having "getLane" and "getLanes" is going to be terribly confusing. Needs a different name
Sorry this is leftover from the previous version, its not used anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139732/new/

https://reviews.llvm.org/D139732



More information about the llvm-commits mailing list