[PATCH] D137125: PPC: Implement null target streamer

[ChenZheng via Phabricator via llvm-commits]

shchenz accepted this revision as: shchenz.
shchenz added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for improving this for PPC.



================
Comment at: llvm/lib/Target/PowerPC/PPCTargetStreamer.h:31
+  virtual void emitAbiVersion(int AbiVersion){};
+  virtual void emitLocalEntry(MCSymbolELF *S, const MCExpr *LocalOffset){};
 };
----------------
arsenm wrote:
> shchenz wrote:
> > Instead of making the base `PPCTargetStreamer` as a null streamer, does it make more sense to add a new child class `PPCTargetNullStreamer`  in `lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.cpp`?
> More boilerplate for no gain 
OK. Seems more targets reuse base class as null streamer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137125/new/

https://reviews.llvm.org/D137125