[PATCH] D137125: PPC: Implement null target streamer

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 19:22:19 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCTargetStreamer.h:31
+  virtual void emitAbiVersion(int AbiVersion){};
+  virtual void emitLocalEntry(MCSymbolELF *S, const MCExpr *LocalOffset){};
 };
----------------
shchenz wrote:
> Instead of making the base `PPCTargetStreamer` as a null streamer, does it make more sense to add a new child class `PPCTargetNullStreamer`  in `lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.cpp`?
More boilerplate for no gain 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137125/new/

https://reviews.llvm.org/D137125



More information about the llvm-commits mailing list