[PATCH] D133340: [PowerPC][GISel]select floating point constant from TOC

Mon Dec 12 16:59:09 PST 2022

arsenm requested changes to this revision.
arsenm added a comment.
This revision now requires changes to proceed.

Can you also add a test in test/MachineVerifier/test_g_constant_pool.mir with the constraints of the instruction

================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:72

+G_CONSTANT_POOL_INDEX
+^^^^^^^^^^^^^^^^^^^^^
----------------
Just G_CONSTANT_POOL?

================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:2639
+
+  unsigned AddrSpace = DL.getAllocaAddrSpace();
+  LLT AddrPtrTy = LLT::pointer(AddrSpace, DL.getPointerSizeInBits(AddrSpace));
----------------
This certainly isn't the alloca addrspace. getDefaultGlobalsAddressSpace maybe?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133340/new/

https://reviews.llvm.org/D133340