[PATCH] D138496: [OMPIRBuilder] Add OpenMPDefaultSimdAlignment field to TargetMachine class

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 08:19:58 PST 2022


jdoerfert added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3074
+  static std::string PreviousFeaturesString;
+  static std::unique_ptr<TargetMachine> TgtInfo;
+  const Target *TheTarget;
----------------
No static variables here, please.
These should be members of the class or a helper class.
Should we have a map of these to the respective TargetMachine?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138496/new/

https://reviews.llvm.org/D138496



More information about the llvm-commits mailing list