[PATCH] D138496: [OMPIRBuilder] Add OpenMPDefaultSimdAlignment field to TargetMachine class

[Dominik Adamski via Phabricator via llvm-commits]

domada added a comment.

Hi Johannes,
I was referring to Jan's idea. He proposes to move part of the functionality to the DataLayout class. IMO this option is not the best approach, because DataLayout object does not contain information about subtarget and we cannot determine if SIMD extensions (avx options) are enabled.

My current patch uses information about subtarget and type of the aligned value to determine the default alignment. If the type of the aligned value is provided I ask DataLayout about preferred alignment (OMPIRBuilder.cpp line 3113).. If this information is not provided I base only on subtarget information.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138496/new/

https://reviews.llvm.org/D138496