[PATCH] D138452: [ConstraintElim] Queue facts and checks directly.

Sun Dec 11 22:42:21 PST 2022

uabelho added a comment.

In D138452#3974119 <https://reviews.llvm.org/D138452#3974119>, @fhahn wrote:

> In D138452#3974011 <https://reviews.llvm.org/D138452#3974011>, @uabelho wrote:
>
>> Hi,
>> The following starts crashing with this patch:
>>
>>   opt -passes=constraint-elimination bbi-76661.ll -o /dev/null
>>
>> I get
>>
>>   opt: ../lib/IR/Instruction.cpp:124: bool llvm::Instruction::comesBefore(const llvm::Instruction *) const: Assertion `Parent == Other->Parent && "cross-BB instruction order comparison"' failed.
>>
>> F25509716: bbi-76661.ll <https://reviews.llvm.org/F25509716>
>
> Thanks for the report. Is it possible this is over-reduced? I cannot reproduce it locally or on godbolt: https://llvm.godbolt.org/z/T8f1q33hq

(I've been OOO a couple of days)
Strange. I tried again and the reproducer I uploaded indeed crashes for me on the commit on main that I tried on last week (83b3304dd2a <https://reviews.llvm.org/rG83b3304dd2a3bee8b6b4f76282adb734a5d1c8ff>).
Anyway, I see that @bjope fixed another repro so you could solve this.
Thanks both of you!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138452/new/

https://reviews.llvm.org/D138452