[PATCH] D138452: [ConstraintElim] Queue facts and checks directly.

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

In D138452#3976219 <https://reviews.llvm.org/D138452#3976219>, @fhahn wrote:

> In D138452#3974418 <https://reviews.llvm.org/D138452#3974418>, @bjope wrote:
>
>> Ok, here is a godbolt repro:   https://llvm.godbolt.org/z/98PvGaTe9
>>
>> The difference is that the branch in the entry block now looks like:
>>
>>   br i1 %0, label %trap, label %1
>
> Thanks, interestingly this doesn't seem to crash on macOS, but I was able to reproduce on Linux. Should be fixed in 9eda78107c4d <https://reviews.llvm.org/rG9eda78107c4d9baca947b7bd9e0ce1c72474a59b>

Great! Fix seem to work. I've cherrypicked the fix and re-enabled ConstraintElimination in our (downstream) fuzzy testing again. Time will tell if we find more problems :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138452/new/

https://reviews.llvm.org/D138452