[PATCH] D139767: [DFAPacketizer] Move DefaultVLIWScheduler class declaration to header file

[Darshan Bhat via Phabricator via llvm-commits]

DarshanRamakant added a subscriber: dexonsmith.
DarshanRamakant added a comment.

In D139767#3986476 <https://reviews.llvm.org/D139767#3986476>, @dexonsmith wrote:

> I don't know much about this code; resigning as reviewer. But I took a quick look. I wonder if this the right fix, or whether `VLIWPacketizerList::VLIWScheduler`'s type should be `ScheduleDAGInstrs`, and downcast when necessary on use, allowing `DefaultVLIWScheduler` to stay private. (Up to others to sort out!)

Thanks @dexonsmith for the suggestion. But I think even if we want to downcast ( dynamic_cast) the declaration should be available to the derived class, which is not the case in the current implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139767/new/

https://reviews.llvm.org/D139767