[PATCH] D139767: [DFAPacketizer] Move DefaultVLIWScheduler class declaration to header file
Duncan P. N. Exon Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 10 09:38:32 PST 2022
dexonsmith resigned from this revision.
dexonsmith added a comment.
I don't know much about this code; resigning as reviewer. But I took a quick look. I wonder if this the right fix, or whether `VLIWPacketizerList::VLIWScheduler`'s type should be `ScheduleDAGInstrs`, and downcast when necessary on use, allowing `DefaultVLIWScheduler` to stay private. (Up to others to sort out!)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139767/new/
https://reviews.llvm.org/D139767
More information about the llvm-commits
mailing list