[PATCH] D136514: [AA][Intrinsics] Add separate_storage assumptions.

Sat Dec 10 01:44:41 PST 2022

nikic added inline comments.

================
Comment at: llvm/test/Analysis/SeparateStorageAliasAnalysis/alias_test.ll:7
+
+; Test basic queries.
+
----------------
davidtgoldblatt wrote:
> nikic wrote:
> > It would be preferable to make this an `aa-eval` test, to test AA directly, rather than a pass using it.
> This is a little hard in the aa-eval of today because of the flow-sensitivity; it can't just print out yes/no/maybe results for all pairs of pointers; it would have to do so out all program locations too. TBAA has a similar sort of issue, uses the same "use gvn to check effects rather than results" trick to get around it too.
> 
> The only aa-eval improvements I could think of were:
> - Do the cubic-size "print AA result for every pair of pointers at every program location" output under a flag
> - Have some sort of magic "print aa-eval results at this location" function
> 
> Both of which seemed like overkill, although I suppose the first is manageable so long as we make sure to keep any test cases sufficiently compact. WDYT?
We could add a mode to print ModRef results rather than AliasResults (like we do for calls). But I think your current test is fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136514/new/

https://reviews.llvm.org/D136514