[PATCH] D133379: [DL] Make vector ABI align bound by element align

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 08:48:37 PST 2022


beanz added a comment.

In D133379#3984033 <https://reviews.llvm.org/D133379#3984033>, @jsilvanus wrote:

> Sure -- but still the behavior on such cases should be clear, even if it is not relevant for DXIL. I just stumbled over the formulation

I don't disagree. That wasn't the problem I was trying to solve with this change.

>> This alters the vector ABI alignment so that vector elements are always aligned appropriately for their type.
>
> that is promising too much in this case.

Fair. That is probably an overly stated comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133379/new/

https://reviews.llvm.org/D133379



More information about the llvm-commits mailing list