[PATCH] D138925: AMDGPU: Add test sanity test if amdgcn.device.{init|fini} already exist

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 07:33:49 PST 2022


sameerds accepted this revision.
sameerds added a comment.
This revision is now accepted and ready to land.

LGTM, with the two nits fixed.



================
Comment at: llvm/test/CodeGen/AMDGPU/lower-ctor-dtor-existing.ll:4
+
+; Make sure something sane happens if amdgcn.device.init or
+; amdgcn.device.fini already exist.
----------------
Rephrase to "do not crash or error out if ..."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138925/new/

https://reviews.llvm.org/D138925



More information about the llvm-commits mailing list