[PATCH] D138925: AMDGPU: Add test sanity test if amdgcn.device.{init|fini} already exist

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 05:02:32 PST 2022


arsenm added a comment.

In D138925#3983720 <https://reviews.llvm.org/D138925#3983720>, @sameerds wrote:

> Redundant word "test" in the first line of the commit description?
>
> Also, how is "something sane" defined? What is the semantics for ctors and dtors that are linked in after init and fini have already been created?

I was thinking "not crash". The actual functionality is driven off the attribute, so it seems like multiple are supposed to work


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138925/new/

https://reviews.llvm.org/D138925



More information about the llvm-commits mailing list