[PATCH] D136319: [GISel] Rework trunc/shl combine in a generic trunc/shift combine

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 19:49:32 PST 2022


arsenm added a comment.

In D136319#3980696 <https://reviews.llvm.org/D136319#3980696>, @Pierre-vh wrote:

> @arsenm I accidentally forgot to leave in the special case to not fold in the presence of G_STORE users. That's why some aarch64 test was failing, see my previous comments.
> Is it still good to land even with the special-case left in?

I forgot about that. Can you file an issue to pick it up later?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136319/new/

https://reviews.llvm.org/D136319



More information about the llvm-commits mailing list