[PATCH] D136319: [GISel] Rework trunc/shl combine in a generic trunc/shift combine
Pierre van Houtryve via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 8 00:41:02 PST 2022
Pierre-vh updated this revision to Diff 481177.
Pierre-vh added a comment.
@arsenm I accidentally forgot to leave in the special case to not fold in the presence of G_STORE users. That's why some aarch64 test was failing, see my previous comments.
Is it still good to land even with the special-case left in?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136319/new/
https://reviews.llvm.org/D136319
Files:
llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
llvm/include/llvm/Target/GlobalISel/Combine.td
llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
llvm/test/CodeGen/AMDGPU/GlobalISel/combine-trunc-shift.mir
llvm/test/CodeGen/AMDGPU/GlobalISel/combine-trunc-shl.mir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136319.481177.patch
Type: text/x-patch
Size: 18272 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221208/e64306c6/attachment.bin>
More information about the llvm-commits
mailing list