[PATCH] D139648: [RISCV] Use vmv.v.i for insertion into lane 0 of undef vector when profitable

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 19:10:48 PST 2022


pcwang-thead added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2838
+  Scalar = DAG.getNode(ExtOpc, DL, XLenVT, Scalar);
+  // We use a vmv.v.i if possible.  We limit this to LMUL2 since the work
+  // done by the vmv.v.i is linear in LMUL.  For the vmv.s.x sequence, we
----------------
Apart from craig's concern about μ-arch implementation, LMUL>1 may increase register pressure so I limited it to LMUL<=1 in my patch, though I haven't assessed the impact of this yet :-).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139648/new/

https://reviews.llvm.org/D139648



More information about the llvm-commits mailing list