[PATCH] D139442: AMDGPU/MC: Make VReg and VISrc decoders more strict

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 10:05:21 PST 2022


Petar.Avramovic added a comment.

Another attempt in D139646 <https://reviews.llvm.org/D139646>, I could to get anything better with tools available in InstPrinter.
OperandType would not make much difference (maybe for printing more verbose error for /*invalid immediate*/), I skipped adding it for now since it was possible to print some meaningful msg without it.

As for better dissasembler diagnostic when sgpr/imm was used in VReg_* and VISrc_*, /*invalid immediate*/ and D139646 <https://reviews.llvm.org/D139646> address them in good enough way.
It would probably be better if we could make more verbose warning than `warning: invalid instruction encoding` in some place before InstrPrinter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139442/new/

https://reviews.llvm.org/D139442



More information about the llvm-commits mailing list