[PATCH] D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:308
+    // Suppress version checking for experimental extensions to prevent erroring
+    // when getting any unknown version.
+    auto ParseResult = RISCVISAInfo::parseArchString(
----------------
s/version/extension/?


================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:311
+        *Attr, /*EnableExperimentalExtension=*/true,
+        /*ExperimentalExtensionVersionCheck=*/false,
+        /*IgnoreUnknown=*/true);
----------------
This means a file that has, say, v0p7, will disassemble as v1p0 rather than being ignored like an extension whose name isn't known?..


================
Comment at: llvm/test/tools/llvm-objdump/ELF/RISCV/objdump.s:9
+	vsetvli a3, a2, e8, m8, tu, mu
\ No newline at end of file

----------------
Fix


================
Comment at: llvm/test/tools/llvm-objdump/ELF/RISCV/unknown-arch-attr.test:4
 ##
 ## The object file has the "rv32i2p0_x1p0_m2p0" arch feature. "x1p0" is an
 ## unrecognized architecture extension. llvm-objdump will ignore it and decode
----------------
This isn't true any more


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139553/new/

https://reviews.llvm.org/D139553