[PATCH] D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute

[Kito Cheng via Phabricator via llvm-commits]

kito-cheng added inline comments.


================
Comment at: llvm/test/MC/RISCV/attribute-with-insts.s:5-8
-# RUN: llvm-mc -triple riscv32 -filetype=obj %s \
-# RUN:   | llvm-objdump --triple=riscv32 -d -M no-aliases - \
-# RUN:   | FileCheck -check-prefix=CHECK-INST %s
-
----------------
Not sure why this removed? I suppose this should still work as well after this patch?


================
Comment at: llvm/test/tools/llvm-objdump/ELF/RISCV/unknown-arch-attr.test:3-4
 ## Encode an unrecognized arch feature into an object file and try to decode it.
-## The expected behavior is to ignore the unrecognized arch feature and
-## continue to process the following arch features.
 ##
----------------
Those comment can keep now :)


================
Comment at: llvm/test/tools/llvm-objdump/ELF/RISCV/unknown-arch-attr.test:11
 
+# Fail as unsupported extension is provided
 # RUN: yaml2obj %s -D BITS=32 -o %t.32.o
----------------
And this can drop now.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/RISCV/unknown-arch-attr.test:36-37
     Type:    SHT_RISCV_ATTRIBUTES
-## The content is the encoding of the arch feature "rv32i2p0_x1p0_m2p0"
-    Content: 412300000072697363760001190000000572763332693270305F783170305F6D32703000
+## The content is the encoding of the arch feature "rv32i2p0_m2p0_x1p0"
+    Content: 412300000072697363760001190000000572763332693270305F6D3270305F7831703000
----------------
Just note why this need change: arch string at least should be canonical order.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139553/new/

https://reviews.llvm.org/D139553