[PATCH] D139625: [mlir][SparseTensor] Add a few tests for sparse vectorization

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 05:08:58 PST 2022


qcolombet created this revision.
qcolombet added reviewers: aartbik, wrengr, Peiming, bixia.
qcolombet added a project: MLIR.
Herald added subscribers: hanchung, jsetoain, Moerafaat, zero9178, anlunx, bzcheeseman, sdasgup3, wenzhicui, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini.
Herald added a project: All.
qcolombet requested review of this revision.
Herald added a reviewer: nicolasvasilache.
Herald added subscribers: pcwang-thead, stephenneuendorffer, nicolasvasilache.

These tests covers mulf, ori, and subi.

NFC

Note: I plan to add more tests to cover the other operators as well (div, add, xor, etc.) but I wanted to double check that the direction was okay first.

BTW, I may have found a bug in the sparsification pass. I found a case where it crashes, but maybe it's because my hand-generated IR is somehow invalid. See https://github.com/llvm/llvm-project/issues/59394 for more details.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139625

Files:
  mlir/test/Dialect/SparseTensor/vectorize_reduction.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139625.481251.patch
Type: text/x-patch
Size: 30994 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221208/d20fcf0d/attachment.bin>


More information about the llvm-commits mailing list