[PATCH] D139624: [llvm][cmake] Use more generator expressions

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 05:01:37 PST 2022


sebastian-ne created this revision.
sebastian-ne added reviewers: tpr, Ericson2314, akyrtzi.
Herald added a subscriber: fedor.sergeev.
Herald added a project: All.
sebastian-ne requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Multi-config builds don’t have CMAKE_BUILD_TYPE set, instead, we should
use generator expressions to switch flags depending on the build type.

Do that for a couple of places that were relatively easy to convert.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139624

Files:
  llvm/cmake/modules/AddLLVM.cmake
  llvm/cmake/modules/HandleLLVMOptions.cmake

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139624.481249.patch
Type: text/x-patch
Size: 11478 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221208/9ff65368/attachment.bin>


More information about the llvm-commits mailing list