[PATCH] D139346: [FuncSpec] Global ranking of specialisations

Thu Dec 8 04:26:03 PST 2022

chill added a comment.

Latest update:

- fixed the bug in calculating the specialisation budget
- let the compiler choose the size of some `SmallVector`s
- moved a few debug prints around

================
Comment at: llvm/include/llvm/Transforms/IPO/FunctionSpecialization.h:84
+// Specialization instance.
+struct Spec {
+  // Original function.
----------------
SjoerdMeijer wrote:
> Nit: perhaps a more descriptive name. The original SpecInfo was a tiny bit better.
It's no easy to come with a more descriptive name, it's just a specialization and `Spec` / `Specs` is quite easy to pronounce.
I don't mind spelling it fully - `Specialization`.
As for "Info", "Data", "Attr",  and similar adornments I support the idea that these suffixes/prefixes do not add any information and are just noise that needs to be avoided as much as possible. (cf. "Clean Code" )

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139346/new/

https://reviews.llvm.org/D139346