[PATCH] D139346: [FuncSpec] Global ranking of specialisations

[Momchil Velikov via Phabricator via llvm-commits]

chill added a comment.

In D139346#3980918 <https://reviews.llvm.org/D139346#3980918>, @labrinea wrote:

> All 12 specializations are coming from get_mem_mv, but only MaxClonesThreshold ought to be kept.

Well, yes and no.

For the "no" part:
We may well create more than `MaxClonesThreshold` specialisations for a single function, as long as the total number of specializations across all functions does not exceed `NumCandidates * MaxClonesThreshold` where `NumCandidates` is the number of functions with at least one specialisation.

For the "yes" part:
There was a bug computing `NumCandidates` in which resulted in the pass doing more specialisations than allowed in this test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139346/new/

https://reviews.llvm.org/D139346