[PATCH] D139551: [AMDGPU] Use CAS loop for min/max atomics at system scope

Wed Dec 7 16:48:13 PST 2022

arsenm added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12986
+  case AtomicRMWInst::UMax: {
+    if (AMDGPU::isFlatGlobalAddrSpace(AS)) {
+      if (RMW->getType()->isFloatTy() && UnsafeFPAtomicsDisabled)
----------------
doru1004 wrote:
> arsenm wrote:
> > I'm pretty sure all of the atomics (except maybe add?) have the same issue, but they don't all need to change at once
> I have the same feeling.
Part of why I think we need D137361 is to get proper lowering for inc/dec for this

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139551/new/

https://reviews.llvm.org/D139551