[PATCH] D139551: [AMDGPU] Use CAS loop for min/max atomics at system scope

[Gheorghe-Teodor Bercea via Phabricator via llvm-commits]

doru1004 added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12986
+  case AtomicRMWInst::UMax: {
+    if (AMDGPU::isFlatGlobalAddrSpace(AS)) {
+      if (RMW->getType()->isFloatTy() && UnsafeFPAtomicsDisabled)
----------------
arsenm wrote:
> I'm pretty sure all of the atomics (except maybe add?) have the same issue, but they don't all need to change at once
I have the same feeling.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139551/new/

https://reviews.llvm.org/D139551