[PATCH] D138991: [AAPointerInfo] handle multiple offsets in PHI

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 09:18:39 PST 2022


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/implicitarg-attributes.ll:67
 
+; CHECK-NOT: .value_kind:     hidden_hostcall_buffer
+; CHECK-NOT: .value_kind:     hidden_multigrid_sync_arg
----------------
I rather dislike CHECK-NOT checks for their fragility, and it's best to be as vague as possible. Probably should remove the .value_kind


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138991/new/

https://reviews.llvm.org/D138991



More information about the llvm-commits mailing list